New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some const-away casts from DQM and validation #25042
Conversation
…tracking/SiStripFineDelayTLA.cc
…GCalValidation.cc
…itsValid.cc Also took the opportunity to replace C-style casts with C++-style casts.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25042/7018 |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: DQM/EcalMonitorTasks @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
The code-checks are being triggered in jenkins. |
Took the opportunity to remove all (unnecessary) |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25042/7042 |
Pull request #25042 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
To clean up static analyzer reports.
Tested in CMSSW_10_4_X_2018-10-25-2300, no changes expected.