-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
used constexpr to avoid link time errors with clang #25047
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25047/7035 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: DataFormats/EcalDigi @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@fabiocos , can we merge this to fix the CLANG IBs. |
+1 DQM differences are unrelated to this PR, they appear in L1T comparisons |
In clang IBs we see errors like [a]. This PR should avoid this link error.
[a]
tmp/slc6_amd64_gcc700/src/CondFormats/EcalObjects/src/CondFormatsEcalObjects/EcalSampleMask.cc.o: In function
EcalSampleMask::setEcalSampleMaskRecordEB(std::vector<unsigned int, std::allocator<unsigned int> > const&)': EcalSampleMask.cc:(.text+0x52f): undefined reference to
EcalDataFrame::MAXSAMPLES'tmp/slc6_amd64_gcc700/src/CondFormats/EcalObjects/src/CondFormatsEcalObjects/EcalSampleMask.cc.o: In function
EcalSampleMask::setEcalSampleMaskRecordEE(std::vector<unsigned int, std::allocator<unsigned int> > const&)': EcalSampleMask.cc:(.text+0xc1f): undefined reference to
EcalDataFrame::MAXSAMPLES'