used constexpr to avoid link time errors with clang

[smuzaffar]

In clang IBs we see errors like [a]. This PR should avoid this link error.

[a]
tmp/slc6_amd64_gcc700/src/CondFormats/EcalObjects/src/CondFormatsEcalObjects/EcalSampleMask.cc.o: In function EcalSampleMask::setEcalSampleMaskRecordEB(std::vector<unsigned int, std::allocator<unsigned int> > const&)': EcalSampleMask.cc:(.text+0x52f): undefined reference to EcalDataFrame::MAXSAMPLES'
tmp/slc6_amd64_gcc700/src/CondFormats/EcalObjects/src/CondFormatsEcalObjects/EcalSampleMask.cc.o: In function EcalSampleMask::setEcalSampleMaskRecordEE(std::vector<unsigned int, std::allocator<unsigned int> > const&)': EcalSampleMask.cc:(.text+0xc1f): undefined reference to EcalDataFrame::MAXSAMPLES'

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25047/7035

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31358/console Started: 2018/10/30 10:49

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/EcalDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 1eb7839
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25047/31358/summary.html

[cmsbuild]

Comparison job queued.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25047/31358/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 173
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994473
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31393/console Started: 2018/10/31 09:52

[cmsbuild]

+1
Tested at: 1eb7839
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25047/31393/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25047/31393/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994645
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[smuzaffar]

@fabiocos , can we merge this to fix the CLANG IBs.

[fabiocos]

+1

DQM differences are unrelated to this PR, they appear in L1T comparisons