New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect delete of an array in RawFile #25058
Conversation
The wrong delete was being called on an array. In addition, the memory in that array was being accessed after the array was deleted. The problem was caught by the static analyzer.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25058/7050 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: IORawData/DTCommissioning @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The wrong delete was being called on an array. In addition, the memory in that array was being accessed after the array was deleted (strtok uses the same memory as is passed to it).
The problem was caught by the static analyzer.