Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 2018 PbPb path #25076

Conversation

goni-zz
Copy link
Contributor

@goni-zz goni-zz commented Oct 31, 2018

related to PR: #25059

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2018

A new Pull Request was created by @goni (Geonhee Oh) for CMSSW_10_3_X.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

backport of #25059

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31406/console Started: 2018/10/31 20:02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25076/31406/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3160179
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3159980
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -406.622 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 140.53 ): -406.622 KiB HLT/Muon
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@goni-zz
Copy link
Contributor Author

goni-zz commented Nov 2, 2018

@andrius-k I can see the dqm is pending in this PR. Can we expect when it is going to other test to merge?

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

@fabiocos I've just been told this PR was desired for data taking. Clearly it's a bit late, but can we go ahead and merge this in case the data taking release is updated for other reasons?

@fabiocos
Copy link
Contributor

fabiocos commented Nov 8, 2018

@mandrenguyen at the last ORP meeting we agreed to wait for a patch for the first collisions, in case some fix is needed there. I am anyway planning an update on the short timescale, including this PR

@fabiocos
Copy link
Contributor

fabiocos commented Nov 8, 2018

+1

@cmsbuild cmsbuild merged commit cd8b9e9 into cms-sw:CMSSW_10_3_X Nov 8, 2018
@mandrenguyen
Copy link
Contributor

@fabiocos Thank you. We also have a request today from the muon POG to add or modify a central skim needed for monitoring the CSCs with RAW-RECO. That PR will come tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants