Updated precomputed value sort

[guitargeek]

The current implementation of precomputed_value_sort requires the passed functions to be functors inheriting from the deprecated binary_/unary_function or functions wrapped in a std::function.

Here, I propose to improve it in a way that it can be used with any function object (in particular normal functions and lambdas). That will allow us to drop the binary_/unary_functions more easily.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25080/7075

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

Utilities/General

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[guitargeek]

Hi @Dr15Jones, can you please test? Since there was this big GitHub network issue 6 days ago I'm not sure if you a) got notified about this PR and just don't care or b) just didn't notified due to the GitHub issue.

[Dr15Jones]

please test
@guitargeek it fell off my radar, sorry. If an L2 hasn't responded to a pull request in a while, I just do a comment with the word 'ping'. That often is enough to get attention.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31489/console Started: 2018/11/06 15:05

[cmsbuild]

+1
Tested at: 714ebf1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25080/31489/summary.html

[cmsbuild]

Comparison job queued.

[Dr15Jones]

+1
Unfortunately the test for this code is not really a unit test since it can never fail (not @guitargeek fault since it was that way from the beginning). I looked at the output of the test and it looks OK.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25080/31489/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2993155
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2992957
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

the modified function is used in several RECO packages, no difference is observed in the PR tests.