Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for concurrent IOVs, use const for products reused by ESProducer #25112

Merged
merged 1 commit into from Nov 8, 2018

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Nov 2, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

RecoLocalTracker/SiStripClusterizer
RecoLuminosity/LumiProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @makortel, @felicepantaleo, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @alesaggio, @gpetruc, @ebrondol, @threus, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@wddgit
Copy link
Contributor Author

wddgit commented Nov 2, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31453/console Started: 2018/11/02 21:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25112/31453/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2993155
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2992956
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Nov 7, 2018

+1

for #25112 73fa996

  • code changes are in line with the PR title. The affected code is actually not used in production now.
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 8, 2018

+1

@cmsbuild cmsbuild merged commit fb7498b into cms-sw:master Nov 8, 2018
@wddgit wddgit deleted the prepareForConcurrentIOVsLastOne branch March 20, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants