Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding unit test for jupyter notebook startup #25120

Merged
merged 2 commits into from Nov 9, 2018

Conversation

davidlange6
Copy link
Contributor

@davidlange6 davidlange6 commented Nov 5, 2018

will work correctly once cms-sw/cmsdist/#4478 is merged

@smuzaffar - any objections to the way an open port is found? I've checked that the timeout does cleanup the process such that the ports freed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

PhysicsTools/PythonAnalysis

@cmsbuild, @fgolf, @peruzzim, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

please test with cms-sw/cmsdist#4478

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4478
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31473/console

@smuzaffar
Copy link
Contributor

@davidlange6 , we do not have netstat installed on arm64 and docker. Try to use /etc/services file.

@davidlange6
Copy link
Contributor Author

davidlange6 commented Nov 5, 2018 via email

@davidlange6
Copy link
Contributor Author

davidlange6 commented Nov 5, 2018 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31528/console Started: 2018/11/08 10:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25120/31528/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25120/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013629
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

please test
lastest IB contains the external needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31547/console Started: 2018/11/09 08:07
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31553/console Started: 2018/11/09 15:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25120/31553/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25120/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Nov 9, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Nov 9, 2018

merge

@cmsbuild cmsbuild merged commit 5277a62 into cms-sw:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants