Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Sunanda's branch #2514

Merged
merged 1 commit into from Feb 19, 2014
Merged

Merge Sunanda's branch #2514

merged 1 commit into from Feb 19, 2014

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Feb 18, 2014

  • HGCal geometry

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

Merge Sunanda's branch

It involves the following packages:

Geometry/CMSCommonData
Geometry/HGCalCommonData
Geometry/HGCalSimData
Validation/CheckOverlap

The following packages do not have a category, yet:

Geometry/HGCalSimData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented Feb 18, 2014

+1

@mark-grimes
Copy link

merge

GEM test; extended pixels test; 3300, 3400, 4100, 4400, 40001, 50002, 60002, 4502, 4500, 5001 and 15001 (old numbering) all fine.

cmsbuild added a commit that referenced this pull request Feb 19, 2014
@cmsbuild cmsbuild merged commit 0d1a57f into cms-sw:CMSSW_6_2_X_SLHC Feb 19, 2014
@ianna ianna deleted the hgcal-algo branch October 26, 2015 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants