Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RawToDigi to Tasks #25162

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Nov 8, 2018

Title says it all. Supersedes #25110 by including a "Task" somewhere in the added task names, and keeping the sequences for "backwards" compatibility (to avoid a massive migration as in #25110). I did migrate three customize functions that replaced a module with a Sequence (because one can't add a Sequence to a Task).

Tested in CMSSW_10_4_X_2018-11-01-2300, no changes expected.

Keeping sequences for to avoid massive migration.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/StandardSequences
EventFilter/CTPPSRawToDigi
L1Trigger/Configuration
SimMuon/CSCDigitizer
SimMuon/DTDigitizer
SimMuon/RPCDigitizer

@perrotta, @cmsbuild, @civanch, @mdhildreth, @nsmith-, @rekovic, @franzoni, @thomreis, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @forthommel, @jan-kaspar, @GiacomoSguazzoni, @jhgoh, @VinInn, @Martin-Grunewald, @ptcox, @rovere, @dildick, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Nov 8, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31543/console Started: 2018/11/08 20:42

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25162/31543/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25162/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 242
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013388
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.281 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 7.3 ): -0.141 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): -0.141 KiB MessageLogger/Errors
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Nov 13, 2018

+1

for #25162 2f469c3

  • code changes are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no relevant differences (ignoring occasionally random changes in DQM plots with the following directory pattern /HLT/Run summary/TAU/\|IsoTaus\|L1TStage2CaloLayer2/NonIsolated[^$]*Tau\|L1TStage2CaloLayer2/Isolated[^$]*Tau\|TausEtEtaPhi\|/L1TEMU)

@makortel
Copy link
Contributor Author

ping

@thomreis
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31786/console Started: 2018/11/21 14:04

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25162/31786/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013109
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.281 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 7.3 ): -0.141 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): -0.141 KiB MessageLogger/Errors
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

+operations

the modifications to the StandardSequences are coherent with the purpose of the PR. A run of 136.85 with the Tracer service enabled confirms that the list of executed modules in a typical Run2 workflow is unchanged.

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 30d2c71 into cms-sw:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants