Migrate RawToDigi to Tasks #25110
Migrate RawToDigi to Tasks #25110
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25110/7103 |
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Configuration/StandardSequences @perrotta, @cmsbuild, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @nsmith-, @rekovic, @franzoni, @jfernan2, @thomreis, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: cb98c33 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25110/7143 |
|
Pull request #25110 was updated. @perrotta, @cmsbuild, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @nsmith-, @rekovic, @franzoni, @jfernan2, @kpedro88, @thomreis, @slava77, @fabiocos, @davidlange6 can you please check and sign again. |
|
@cmsbuild, please test I found out that my earlier downstream migration was not complete (sorry about that), so here is a new attempt (still with |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
| + process.muonRPCDigis) | ||
| process.RawToDigi.replace(process.muonRPCDigis, \ | ||
| process.filteredRPCDigiSequence) | ||
| process.filteredRPCDigiTask = cms.task(process.preRPCDigis, |
There was a problem hiding this comment.
Thanks Kevin (and actually all this can be replaced with RawToDigi.add(process.preRPCDigis), which I did in #25162).
|
Closing in favor of #25162 (that avoids a massive migration, sorry for the noise). |
Title says it all. I migrated all downstream configurations I managed to find with
git grep.Workflows with generator filters need #25084 (which is already merged but not yet in an IB) in addition.
Tested in CMSSW_10_4_X_2018-11-01-2300, no changes expected.