Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[104X]Change GT. Fix Pedestal Tag in Relval Offline GT #25164

Merged
merged 2 commits into from Nov 10, 2018

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Nov 8, 2018

Change 103X_dataRun2_relval GT reverting ECAL pedestal to EcalPedestals_express.

@lpernie
Copy link
Contributor Author

lpernie commented Nov 8, 2018

test workflow 1010.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31545/console Started: 2018/11/08 22:05

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

A new Pull Request was created by @lpernie (Luca Pernie) for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25164/31545/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25164/1010.0_TestEnableEcalHCAL2017B+TestEnableEcalHCAL2017B+TIER0EXPTE+ALCAEXPTE+ALCAHARVDTE
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25164/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1974 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 328
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3013296
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Nov 9, 2018

@lpernie @tocheng the crash itself is fixed. Do you understand why touching ECAL pedestals affecting 2017 modifies the b-tagging output in 2016 tests (136.731)? As far as I can see in

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_dataRun2_relval_v7/103X_dataRun2_relval_v8

this change does not affect only ECAL pedestals, is this explicitly intended?

If this is ok and desired, please sign this PR so as we can fix the issue and move forward with 10_4_0_pre2 build

@lpernie
Copy link
Contributor Author

lpernie commented Nov 9, 2018

Hi @fabiocos ,
The change only affect the ECAL pedestal Tag. The rest of the differences are due to the different Snapshot Time.
Still we are discussing with ECAL if the change in pedestal in this queue is something desired. We hope to converge soon.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

The code-checks are being triggered in jenkins.

@lpernie
Copy link
Contributor Author

lpernie commented Nov 9, 2018

test workflow 1010.0

@lpernie
Copy link
Contributor Author

lpernie commented Nov 9, 2018

@fabiocos this is the changes agreed with ECAL people.
Basically we use Prompt Tag for the Pedestal.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31561/console Started: 2018/11/09 17:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Pull request #25164 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25164/31561/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25164/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1974 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 328
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3013296
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Nov 9, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants