Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMTF new LCT coordinate conversion LUTs for 10_3_X DQM #25169

Merged

Conversation

abrinke1
Copy link
Contributor

@abrinke1 abrinke1 commented Nov 9, 2018

Back-port of #24766 (or forward-port of #24643) to use proper primitive coordinate LUTs in emulator. Currently in the Heavy Ion runs, we are seeing ~30% data-emulator disagreement in the Online DQM: https://tinyurl.com/ydzbs6wf

For this to work, the most recent change to the external conditions in L1Trigger/L1TMuon/data (pulled into the "master" branch on September 25 [1]) must be in CMSSW_10_3_1. @rekovic , @thomreis , or anyone else: do you know how to see what external conditions are included in a given CMSSW release?

If these externals are not there yet, I'll have to make another commit to modify this branch, so that it will work for the DQM.

Cheers,
Andrew

[1] cms-data/L1Trigger-L1TMuon@29a8863

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

A new Pull Request was created by @abrinke1 for CMSSW_10_3_X.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

thomreis commented Nov 9, 2018

please test

@thomreis
Copy link
Contributor

thomreis commented Nov 9, 2018

backport of #24766

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31551/console Started: 2018/11/09 12:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25169/31551/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3160863
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3160664
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@thomreis
Copy link
Contributor

thomreis commented Nov 9, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@rekovic @thomreis is this PR specifically needed for the HI data taking?

@abrinke1
Copy link
Contributor Author

Hi @fabiocos ,
It is only needed for the DQM, and it has now been deployed at P5. Since it's already in 9_2_X and 9_4_X, I think it makes sense for it to go into 9_3_X whenever the next version is cut - but it is not necessary for HI running, or urgent for any other reason.
Best,
Andrew

@fabiocos
Copy link
Contributor

@abrinke1 I think you mean 10_X_Y... Anyway, in 10_2_X #24643 was closed as no more used for data taking. 10_3_X is in use for HI data taking, the only one left until 2021.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7f31c57 into cms-sw:CMSSW_10_3_X Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants