New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMTF new LCT coordinate conversion LUTs for 10_3_X DQM #25169
EMTF new LCT coordinate conversion LUTs for 10_3_X DQM #25169
Conversation
A new Pull Request was created by @abrinke1 for CMSSW_10_3_X. It involves the following packages: L1Trigger/L1TMuonEndCap @nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
backport of #24766 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Hi @fabiocos , |
+1 |
Back-port of #24766 (or forward-port of #24643) to use proper primitive coordinate LUTs in emulator. Currently in the Heavy Ion runs, we are seeing ~30% data-emulator disagreement in the Online DQM: https://tinyurl.com/ydzbs6wf
For this to work, the most recent change to the external conditions in L1Trigger/L1TMuon/data (pulled into the "master" branch on September 25 [1]) must be in CMSSW_10_3_1. @rekovic , @thomreis , or anyone else: do you know how to see what external conditions are included in a given CMSSW release?
If these externals are not there yet, I'll have to make another commit to modify this branch, so that it will work for the DQM.
Cheers,
Andrew
[1] cms-data/L1Trigger-L1TMuon@29a8863