restoring ecal pulse shape hard-coded-thresholds when not using DB #25170
Conversation
…ode (not using DB, expert mode)
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25170/7169 |
|
A new Pull Request was created by @theofil (Konstantinos Theofilatos) for master. It involves the following packages: SimCalorimetry/EcalSimAlgos @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@theofil as far as I can see this is not the fix of a missing initialization (it is anyway done in EcalShapeBase constructor) but just restoring backward compatibility, do I understand correctly? |
|
+1 |
|
That's right, if somebody would try to use the shape in an old style
withouth fetching data from DB and without using the time tranlsation of t
+ t0 = t + t_rise - 5*adc_clock as cmssw does upon digitization then he
would see difference. Probably nobody would ever want to do that, still I
thought of fixing it now that the code is still fresh in my memory
…On Sat, Nov 10, 2018, 18:07 Fabio Cossutti ***@***.***> wrote:
@theofil <https://github.com/theofil> as far as I can see this is not the
fix of a missing initialization (it is anyway done in EcalShapeBase
constructor) but just restoring backward compatibility, do I understand
correctly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25170 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEde8iGSKQtwgnEqTmhMgLkoVrjmkV9dks5utwe2gaJpZM4YWc-a>
.
|
This PR should not introduce any noticeable change anywhere in MC production or data reconstruction.
Within CMSSW, the pulse shape's thresholds are private members of the EcalShapeBase class and are not directly used anywhere. By default for >= CMSSW_10_3_0_pre5, the pulse shape data are fetched from DB and the hard-coded values are ignored. The restoration of the hard-coded thresholds are to needed in case an expert tries to use the Phase-I compatibility mode of the class, which is not using the DB, and tries to evaluate the shape(time) on its own. The thresholds are not explicitly used by the Digitization/Reconstruction code of CMSSW.