Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backported StoredMergeableRunProductMetadata #25171

Conversation

Dr15Jones
Copy link
Contributor

In order to attempt to make CMSSW_10_X files forward compatible with
CMSSW_8_0 (for possible use in the ultra legacy processing) ROOT
needs the dictionary for the type StoredMergeableRunProductMetadata.

In order to attempt to make CMSSW_10_X files forward compatible with
CMSSW_8_0 (for possible use in the ultra legacy processing) ROOT
needs the dictionary for the type StoredMergeableRunProductMetadata.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/Provenance

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@rovere, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31556/console Started: 2018/11/09 16:30

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25171/31556/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 1038996
  • DQMHistoTests: Total failures: 1026
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1037872
  • DQMHistoTests: Total skipped: 98
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -14 KiB( 14 files compared)
  • Checked 61 log files, 7 edm output root files, 15 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 834bff1 into cms-sw:CMSSW_8_0_X Nov 13, 2018
@Dr15Jones Dr15Jones deleted the backportStoredMergeableRunProductMetadata branch December 10, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants