Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add another PbPb central skim for the muon POG #25172

Merged
merged 5 commits into from Nov 14, 2018
Merged

Add another PbPb central skim for the muon POG #25172

merged 5 commits into from Nov 14, 2018

Conversation

mandrenguyen
Copy link
Contributor

The muon POG requires a central skim for PbPb collisions with a single muon trigger for monitoring the CSCs.

@cmsbuild cmsbuild added this to the CMSSW_10_4_X milestone Nov 9, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

The code-checks are being triggered in jenkins.

@mandrenguyen
Copy link
Contributor Author

Tested with skims -s SKIM:ZMu+PbPbZMM+PbPbZEE --data -n 100 --conditions auto:com10 --python_filename=PbPb_SKIMs2.py --processName=SkimsPbPb --no_exec --era=Run2_2018 --filein file:/afs/cern.ch/work/m/mnguyen/public/skims2018/step3_RAW2DIGI_L1Reco_RECO.root

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25172/7175

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

Configuration/Skimming

@pgunnell, @zhenhu, @prebello, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Nov 9, 2018

please test workflow 140.56,140.57

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31564/console Started: 2018/11/09 17:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

+1
Tested at: 0afa180
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25172/31564/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25172/31564/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25172/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25172/140.57_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25172/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@mandrenguyen mandrenguyen mentioned this pull request Nov 10, 2018
Merged
fabiocos
fabiocos reviewed Nov 11, 2018
View reviewed changes
Configuration/Skimming/python/Skims_PbPb_cff.py Outdated
ZMuSkimPath = cms.Path( diMuonSelSeq )
SKIMStreamZMu = cms.FilteredStream(
responsible = 'HI PAG',
name = 'ZMu',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandrenguyen for naming consistency with the other skims I would pre-pend a PbPb to ZMu

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25172/7244

@cmsbuild
Copy link
Contributor

Pull request #25172 was updated. @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please check and sign again.

@fabiocos
Copy link
Contributor

please test workflow 140.56,140.57 with #25210

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31642/console Started: 2018/11/13 22:22

@cmsbuild
Copy link
Contributor

+1
Tested at: 79e1f44
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25172/31642/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1a14841
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25172/31642/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25172/31642/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25172/31642/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25172/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013102
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@prebello @zhenhu @kpedro88 I think this skim could move forward, please check and sign, we need a backport for HI data taking

@zhenhu
Copy link
Contributor

zhenhu commented Nov 14, 2018

+1

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@kpedro88 this is not upgrade specific, in case please sign it for reference

@cmsbuild cmsbuild merged commit 0297e81 into cms-sw:master Nov 14, 2018
@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocos fabiocos fabiocos left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_10_4_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mandrenguyen @cmsbuild @fabiocos @prebello @zhenhu @kpedro88