Save repacked raw data in FVT, for express wfs #25178
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25178/7177 |
|
A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master. It involves the following packages: Configuration/EventContent @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| for _entry in [FEVTDEBUGEventContent,FEVTDEBUGHLTEventContent,FEVTEventContent]: | ||
| run2_GEM_2017.toModify(_entry, outputCommands = _entry.outputCommands + ['keep *_muonGEMDigis_*_*']) | ||
| run3_GEM.toModify(_entry, outputCommands = _entry.outputCommands + ['keep *_muonGEMDigis_*_*']) | ||
| phase2_muon.toModify(_entry, outputCommands = _entry.outputCommands + ['keep *_muonGEMDigis_*_*']) | ||
|
|
||
| pp_on_AA_2018.toModify(_entry, outputCommands = _entry.outputCommands + ['keep FEDRawDataCollection_rawDataRepacker_*_*']) |
There was a problem hiding this comment.
why does this need to be handled separately from the rest?
There was a problem hiding this comment.
@davidlange6 do you mean not modifying directly the RAW content?
There was a problem hiding this comment.
there is no simple obvious alternative that's clearly not going to break anything outside of pp_on_AA
There was a problem hiding this comment.
@slava77 the initial simple attempt to modify RAW was not working...
There was a problem hiding this comment.
@slava77 the initial simple attempt to modify RAW was not working...
I'm not sure if this is connected with David's comment
There was a problem hiding this comment.
@slava77 well, the modification tried was just for pp_on_AA, changing the base definition is different. I do not see how this change might break other things, and I have checked that it solves the observed problem, so in principle it may be merged if a fast patch is needed
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Testing express with Configuration/DataProcessing on recent data python RunExpressProcessing.py --scenario ppEra_Run2_2018_pp_on_AA --global-tag 103X_dataRun2_Express_v2 --lfn /store/t0streamer/Data/HIExpress/000/326/398/run326398_ls0502_streamHIExpress_StorageManager.dat --fevt --dqmio --alcarecos=TkAlMinBias+SiStripCalZeroBias I get for the fevt output edmDumpEventContent output.root | grep FED with the desired collection as intended for FEVT |
|
Right -as done for the other changes in the pr. We want to protect against something?
On 9 Nov 2018, at 17:41, Fabio Cossutti <notifications@github.com<mailto:notifications@github.com>> wrote:
@fabiocos commented on this pull request.
________________________________
In Configuration/EventContent/python/EventContent_cff.py<#25178 (comment)>:
for _entry in [FEVTDEBUGEventContent,FEVTDEBUGHLTEventContent,FEVTEventContent]:
run2_GEM_2017.toModify(_entry, outputCommands = _entry.outputCommands + ['keep *_muonGEMDigis_*_*'])
run3_GEM.toModify(_entry, outputCommands = _entry.outputCommands + ['keep *_muonGEMDigis_*_*'])
phase2_muon.toModify(_entry, outputCommands = _entry.outputCommands + ['keep *_muonGEMDigis_*_*'])
-
+ pp_on_AA_2018.toModify(_entry, outputCommands = _entry.outputCommands + ['keep FEDRawDataCollection_rawDataRepacker_*_*'])
@davidlange6<https://github.com/davidlange6> do you mean not modifying directly the RAW content?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#25178 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywx95HRCmwyGefgfydldn3GL4FvXOks5utbAFgaJpZM4YW4hc>.
|
I have less doubts about having GEMdigis in the default (without eras): they can be moved to the default. |
|
+operations the fix adds the FEDRawDataCollection to the FEVT event output as requested |
cmsbuild
added
fully-signed
operations-approved
and removed
operations-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
The RAW data with label rawDataRepacker is missing from express reco, which should store FVT content.
This adds it. Was tested by re-running express on streamers.