Validation/Geometry: Tracker Air Categorization

[vargasa]

Logs were showing that Air was being sent to 'Other' Category:

MaterialBudgetData: Material forced to 'Other': Air in volume Tracker

Air itself is not part of the tracker maps (x0, x1), and it may be related with a previous issue #23734 in which Air category histograms were rendering empty.

This PR addresses this issue as well as make independent Tracker/HGCal building maps process and some cleaning. @apsallid confirmed none of these changes affect HGCal work

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25231/7253

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31654/console Started: 2018/11/14 18:21

[cmsbuild]

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

Validation/Geometry

@andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @civanch can you please review it and eventually sign? Thanks.
@rishabhCMS, @rovere, @rbartek this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 63be60a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25231/31654/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25231/31654/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013101
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[andrius-k]

+1

[cvuosalo]

+geometry

[cvuosalo]

+1
Trying to approve for geometry again

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@vargasa this PR removes several LogInfo dumping information about the material. Are they not considered any more interesting?

[vargasa]

@fabiocos none of the removed code was being executed as stated in the commit description

[fabiocos]

@vargasa ok, thanks for the clarification. I am not sure why the matTable was empty (could you please clarify ?), but of course if this is the case it makes sense.

[fabiocos]

+1

[vargasa]

@fabiocos The map for the categorization process that is being used is created in a later stage, this matSize==0 is the default size for the table G4Material::GetMaterialTable() check fIndexTable. It is hard to see why or how this logic was used in the past as there is no history beyond Snapshot of CMSSW_6_2_0_pre8