XML Units Checker

[ianna]

This is a helper script to check units consistency
as discussed during Sim meeting.

To run

python UnitsCheck.py DetectorDescription/DDCMS/data/materials.xml

intended output:

...
Line # 4661 WARNING: Numerical values without units: 
   <MaterialFraction fraction="0.2158">

_______________________________^________
 
Line # 4665 Units defined: 
  <CompositeMaterial name="LYSO" density="7.11*g/cm3" symbol=" " method="mixture by weight">

__________________________________________^__________________________________________________

...

@civanch - FYI

[ianna]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25236/7256

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31656/console Started: 2018/11/14 18:28

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 8b91277
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25236/31656/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25236/31656/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013096
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

[civanch]

Hi Ianna, material fraction is a unitless variable. Cheers, Vladimir

…

On Wed, 14 Nov 2018, Ianna Osborne wrote: This is a helper script to check units consistency as discussed during Sim meeting. To run python UnitsCheck.py DetectorDescription/DDCMS/data/materials.xml intended output: ... Line # 4661 WARNING: Numerical values without units: <MaterialFraction fraction="0.2158"> _______________________________^________ Line # 4665 Units defined: <CompositeMaterial name="LYSO" density="7.11*g/cm3" symbol=" " method="mixture by weight"> __________________________________________^__________________________________________________ ... @civanch - FYI ____________________________________________________________________________________________________________________ You can view, comment on, or merge this pull request online at:   #25236 Commit Summary * Units checker File Changes * A DetectorDescription/DDCMS/test/python/UnitsCheck.py (69) Patch Links: * https://github.com/cms-sw/cmssw/pull/25236.patch * https://github.com/cms-sw/cmssw/pull/25236.diff ? You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.[AEub7hAI1dHYOcq9h2Q-Hq-Zes3nZevUks5uvEdngaJpZM4YeIdT.gif]

[davidlange6]

hi @ianna -
as you mentioned to me - the print syntax should be updated - some examples in #23825

otherwise, modulo @civanch comment - maybe you should just make a GitHub issue with the results of your script on all the geometry files in cmssw? (somehow grouped if there are lots and lots)

[ianna]

@davidlange6 and @civanch - thanks! I'll update the script to use print function and exclude some obvious cases: MaterialFraction, etc.

[fabiocos]

@ianna a bit special case perhaps:

Line # 907 WARNING: Numerical values without units:

^_________________________________

the script does not technically fail, but some logic protection could improve its usefulness

[ianna]

@fabiocos - thanks! I'll fix it.