Convert auto_ptr to unique_ptr in SimDataFormats/GeneratorProducts. #25239

gartung · 2018-11-14T20:40:24Z

Added ioread rules to allow reading old root file using pdf_=auto_ptr.

gartung · 2018-11-14T20:41:43Z

Resubmit of #25192
Requires ROOT patch
root-project/root#2960

cmsbuild · 2018-11-14T20:42:39Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-11-14T20:45:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25239/7258

cmsbuild · 2018-11-14T20:45:30Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

SimDataFormats/GeneratorProducts

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

efeyazgan · 2018-11-16T15:24:02Z

please test

cmsbuild · 2018-11-16T15:24:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31697/console Started: 2018/11/16 18:03

gartung · 2018-11-16T17:40:42Z

Requires update to ROOT v6-14-00-patches
cms-sw/cmsdist#4508

gartung · 2018-11-16T17:42:36Z

please abort 31697

cmsbuild · 2018-11-16T18:19:51Z

-1

Tested at: 73cef9e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25239/31697/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

RelVals:

When I ran the RelVals I found an error in the following worklfows:
8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

7.3 step2

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step2_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

150.0 step2

runTheMatrix-results/150.0_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018/step2_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018.log

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

158.0 step2

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

11624.0 step2

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10224.0 step2

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

27434.0 step2

runTheMatrix-results/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35.log

250202.181 step3

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step3_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Nov 16 19:16:02 2018-date Fri Nov 16 19:04:44 2018 s - exit: 22016
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Fri Nov 16 19:12:11 2018-date Fri Nov 16 19:04:46 2018 s - exit: 22016
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Nov 16 19:12:04 2018-date Fri Nov 16 19:04:50 2018 s - exit: 22016
cmsDriver.py RelVal -s HLT:2018v36,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2018v36 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v36_MC.root --fileout file:RelVal_Raw_2018v36_MC_HLT_RECO.root : FAILED - time: date Fri Nov 16 19:16:09 2018-date Fri Nov 16 19:05:03 2018 s - exit: 22016
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018_pp_on_AA --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Fri Nov 16 19:13:42 2018-date Fri Nov 16 19:05:04 2018 s - exit: 22016
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Fri Nov 16 19:11:27 2018-date Fri Nov 16 19:05:09 2018 s - exit: 22016
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Fri Nov 16 19:12:29 2018-date Fri Nov 16 19:05:13 2018 s - exit: 22016
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Fri Nov 16 19:12:03 2018-date Fri Nov 16 19:05:23 2018 s - exit: 22016

cmsbuild · 2018-11-16T18:19:53Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

…ratorProducts-strictcxx17

fabiocos · 2019-05-21T09:16:06Z

@efeyazgan @qliphy @alberto-sanchez might a test be done on some old GEN file with pdf info?

fabiocos · 2019-06-03T07:28:57Z

@efeyazgan @qliphy @alberto-sanchez ping, might a test be done on some old GEN file with pdf info?

efeyazgan · 2019-06-04T13:08:58Z

@fabiocos what do you mean by old GEN file?

@Saptaparna @gourangakole

fabiocos · 2019-06-05T07:07:57Z

@efeyazgan files produced with previous ROOT and PDF versions (already 10_2_X is old in this sense)

fabiocos · 2019-06-17T12:33:31Z

@efeyazgan @Saptaparna @gourangakole any news on this PR?

Saptaparna · 2019-06-17T15:48:42Z

@fabiocos I have generated a GEN-only root file in 10_2_X. Should I now use this GEN-only file to create step2 and step3 files in both 10_2_X and a higher release and compare the distributions associated with physics variables? Thanks!

fabiocos · 2019-06-18T11:44:26Z

@Saptaparna I think it is enough a GEN validation comparing results reading your sample in 10_2_X and 11_0_X

fabiocos · 2019-06-27T09:47:09Z

@Saptaparna @efeyazgan @qliphy do we finally have a conclusion? I think we need to close this story at some point

Saptaparna · 2019-06-27T15:29:41Z

@fabiocos I have launched the validation jobs in 10_2_6 and 11_0_0_pre2. However, there are some issues right now with logging into sl7 machines at LPC and the 11_0_0_pre2 are all in idle state. I will switch to CERN and launch those jobs.

fabiocos · 2019-07-11T19:59:34Z

@Saptaparna sorry, do we finally have a result? The test to be performed should be pretty minimal...

Saptaparna · 2019-07-12T03:42:06Z

@fabiocos I am very sorry. The last couple of weeks have been very busy (I had made some prior work commitments that needed to be met). I also had analysis deadlines that needed to be met. I am getting back to this now and will report on progress asap.

Saptaparna · 2019-07-15T18:47:43Z

@fabiocos Here are some comparisons between 10_2_6 and 11_0_0_pre2:

http://uaf-10.t2.ucsd.edu/~sapta/validation_10X_vs_11X/Generator_TTbar.html

for a TTbar sample. The red line represents 10_2_6 while the blue dots represent 11_0_0_pre2. The statistics is an issue here, but that is because I had a lot of trouble producing the files in 11_X. There were lots of condor failures etc. Please let me know if you would like me to perform any other specific tests. Thanks.

Saptaparna · 2019-07-16T14:41:08Z

@fabiocos : I have updated the link. I noticed the other link I had pasted could not be accessed later in the day.

kpedro88 · 2019-07-29T19:11:42Z

@Saptaparna is the conclusion from your linked test that everything is fine?

Saptaparna · 2019-07-30T12:19:18Z

@kpedro88 Things look fine but I'd like to hear from @fabiocos on any further cross checks.

gartung · 2019-09-06T18:33:55Z

ping

fabiocos · 2019-09-09T08:51:14Z

For what I can see, analyzing the output of some LHE-based test wf (e.g. 514.0 or 521.0) with the DummyLHEAnalyzer, the result is the same with or without this PR.
@qliphy @agrohsje do we have samples where the pdf section affected by this PR is touched, apart for the arrays of weights? Otherwise, unless you have further checks to propose, I would move forward with this PR.

agrohsje · 2019-09-09T10:46:09Z

+1

cmsbuild · 2019-09-09T10:46:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-09-09T20:20:41Z

+1

Convert auto_ptr to unique_ptr in SimDataFormats/GeneratorProducts.

73cef9e

Added ioread rules to allow reading old root file using pdf_=auto_ptr.

cmsbuild added this to the CMSSW_10_4_X milestone Nov 14, 2018

cmsbuild added code-checks-pending comparison-pending generators-pending orp-pending pending-signatures tests-pending labels Nov 14, 2018

gartung mentioned this pull request Nov 14, 2018

Update root 6.12.x to get bug fix for std::unique_ptr cms-sw/cmsdist#4501

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 14, 2018

cmsbuild added tests-started and removed tests-pending labels Nov 16, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Nov 16, 2018

Merge remote-tracking branch 'origin/master' into SimDataFormats-Gene…

26a1b59

…ratorProducts-strictcxx17

cmsbuild removed code-checks-approved comparison-notrun labels Dec 19, 2018

cmsbuild added the comparison-available label May 20, 2019

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Sep 9, 2019

cmsbuild added orp-approved and removed orp-pending labels Sep 9, 2019

cmsbuild merged commit 36f01ea into cms-sw:master Sep 9, 2019

gartung deleted the SimDataFormats-GeneratorProducts-strictcxx17 branch September 9, 2019 20:24

makortel mentioned this pull request Nov 28, 2023

Reading old files containing std::auto_ptr<gen::PdfInfo> #43422

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert auto_ptr to unique_ptr in SimDataFormats/GeneratorProducts. #25239

Convert auto_ptr to unique_ptr in SimDataFormats/GeneratorProducts. #25239

gartung commented Nov 14, 2018

gartung commented Nov 14, 2018

cmsbuild commented Nov 14, 2018

cmsbuild commented Nov 14, 2018

cmsbuild commented Nov 14, 2018

efeyazgan commented Nov 16, 2018

cmsbuild commented Nov 16, 2018 •

edited

gartung commented Nov 16, 2018

gartung commented Nov 16, 2018

cmsbuild commented Nov 16, 2018

cmsbuild commented Nov 16, 2018

fabiocos commented May 21, 2019

fabiocos commented Jun 3, 2019

efeyazgan commented Jun 4, 2019 •

edited

fabiocos commented Jun 5, 2019

fabiocos commented Jun 17, 2019

Saptaparna commented Jun 17, 2019

fabiocos commented Jun 18, 2019

fabiocos commented Jun 27, 2019

Saptaparna commented Jun 27, 2019

fabiocos commented Jul 11, 2019

Saptaparna commented Jul 12, 2019

Saptaparna commented Jul 15, 2019 •

edited

Saptaparna commented Jul 16, 2019 •

edited

kpedro88 commented Jul 29, 2019

Saptaparna commented Jul 30, 2019

gartung commented Sep 6, 2019

fabiocos commented Sep 9, 2019

agrohsje commented Sep 9, 2019

cmsbuild commented Sep 9, 2019

fabiocos commented Sep 9, 2019

Convert auto_ptr to unique_ptr in SimDataFormats/GeneratorProducts. #25239

Convert auto_ptr to unique_ptr in SimDataFormats/GeneratorProducts. #25239

Conversation

gartung commented Nov 14, 2018

gartung commented Nov 14, 2018

cmsbuild commented Nov 14, 2018

cmsbuild commented Nov 14, 2018

cmsbuild commented Nov 14, 2018

efeyazgan commented Nov 16, 2018

cmsbuild commented Nov 16, 2018 • edited

gartung commented Nov 16, 2018

gartung commented Nov 16, 2018

cmsbuild commented Nov 16, 2018

cmsbuild commented Nov 16, 2018

fabiocos commented May 21, 2019

fabiocos commented Jun 3, 2019

efeyazgan commented Jun 4, 2019 • edited

fabiocos commented Jun 5, 2019

fabiocos commented Jun 17, 2019

Saptaparna commented Jun 17, 2019

fabiocos commented Jun 18, 2019

fabiocos commented Jun 27, 2019

Saptaparna commented Jun 27, 2019

fabiocos commented Jul 11, 2019

Saptaparna commented Jul 12, 2019

Saptaparna commented Jul 15, 2019 • edited

Saptaparna commented Jul 16, 2019 • edited

kpedro88 commented Jul 29, 2019

Saptaparna commented Jul 30, 2019

gartung commented Sep 6, 2019

fabiocos commented Sep 9, 2019

agrohsje commented Sep 9, 2019

cmsbuild commented Sep 9, 2019

fabiocos commented Sep 9, 2019

cmsbuild commented Nov 16, 2018 •

edited

efeyazgan commented Jun 4, 2019 •

edited

Saptaparna commented Jul 15, 2019 •

edited

Saptaparna commented Jul 16, 2019 •

edited