DD4hep: Add Division Volume

[ianna]

• Add a Division tag parser
• Make context private and provide read/write accessors
• Clear context when done with it
• Change naming according to Coding style rules
• Process Algorithms defined in a PosPartSection (should all Algorithms be part of this section?)

[cmsbuild]

The code-checks are being triggered in jenkins.

[ianna]

please test

[ianna]

please test

[ianna]

@smuzaffar - I cannot trigger the tests for this PR

[ianna]

please test

[smuzaffar]

I am checking

[smuzaffar]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25252/7301

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31733/console Started: 2018/11/19 16:24

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

@ianna , bot only recognize commands once code-checks are passed. In this case, the jenkins job for code checks fail for some unknow reason (may be a github glitch https://cmssdt.cern.ch/jenkins/job/run-pr-code-ckecks/7273/console ).

anyway, it runs fine and tests are now running

[cmsbuild]

-1

Tested at: 86626cf

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25252/31733/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

[ianna]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25252/7321

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31755/console Started: 2018/11/20 12:44

[cmsbuild]

Pull request #25252 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

[cmsbuild]

+1
Tested at: 664f676
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25252/31755/summary.html

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25252/31755/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013111
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

@ianna the CMSSW code rules checker complains about the try-check constructs used in this package, although they are not directly coming from this PR. Is it possible to clean them in some way?
Not sure how in this case...

[ianna]

@fabiocos - Could you, please, point me to the link?

[fabiocos]

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25252/31755/codeRules/cmsCodeRule3.txt

[ianna]

@fabiocos - this try bloc is treating DDAlgorithm plugins, e.g. what the DPGs will be working on. I think, while they are debugging the code it is better to print a message then crash or stop. I'll clean it up later when it the DDAlgorithm migration is done.

[fabiocos]

+1