Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding test code for RecoMET #2526

Merged
merged 11 commits into from Feb 25, 2014
Merged

Conversation

TaiSakuma
Copy link
Contributor

add integration tests in RecoMET/METProducers

It tests if the following modules to produce various definitions of METs run without an error:
genMetCalo, genMetCaloAndNonPrompt, genMetTrue, genMetIC5GenJets, met, metNoHF, metHO, metNoHFHO, metOpt, metOptNoHF, metOptHO, metOptNoHFHO, htMetAK5, corMetGlobalMuons, tcMet, tcMetCST, tcMetRft2, tcMetVedu, tcMetWithPFclusters, pfMet, pfClusterMet, pfChargedMET

It doesn't test if the contents are right.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_1_X.

code-cleaning in RecoMET

It involves the following packages:

RecoMET/METProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
I ran the usual tests and I found errors in the following unit tests:

---> test TestDriver had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2526/219/summary.html

@TaiSakuma
Copy link
Contributor Author

I commented out all test TaiSakuma@7475042 becauset the test input file is not always found. I will think about the input file later.

@cmsbuild
Copy link
Contributor

Pull request #2526 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@slava77
Copy link
Contributor

slava77 commented Feb 24, 2014

Hi Tai

Please change the subject of the PR to something more descriptive.
Code cleaning, sounds like something was removed. In this case, only new tests are added

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2014

+1

#2526 7475042

based on jenkins

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@TaiSakuma
Copy link
Contributor Author

@slava77, that is a good point. i changed it.

ktf added a commit that referenced this pull request Feb 25, 2014
Reco -- Adding test code for RecoMET
@ktf ktf merged commit a6de567 into cms-sw:CMSSW_7_1_X Feb 25, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants