Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AsciiOutputModule to print out alias branches, and extend EventContentAnalyzer to optionally print provenance information #25265

Merged
merged 2 commits into from Nov 19, 2018

Conversation

makortel
Copy link
Contributor

This PR includes two related changes for investigating in detail the provenance information of EDAlias products:

AsciiOutputModule

Event::getAllProvenance() ignores alias branches, so AsciiOutputModule ignores alias branches as well. In order to print those, I

  • changed the approach to get the list of branches from ConstProductRegistry instead
  • added a printout whether the branch is an alias for some other branch
  • optionally (verbosity > 2) print out the PSet of the module producing the branch (and in case of alias, of the module alias is for)

EventContentAnalyzer

I added an option (listProvenance) to print out (event by event) provenance information for the branches.

Tested in CMSSW_10_4_0_pre2, no changes expected.

@Dr15Jones

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@@ -472,6 +509,8 @@ namespace edm {
np = desc.addOptionalUntracked<bool>("listContent", true);
np->setComment("If true then print a list of all the event content.");

np = desc.addOptionalUntracked<bool>("listProvenance", false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr15Jones Is there a good reason for these to be optional, given that all of them have default values? Now the defaults are specified twice.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Modules

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31700/console Started: 2018/11/16 18:27

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25265/31700/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013076
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

cross-checked in a simple standalone test

@cmsbuild cmsbuild merged commit 9e56120 into cms-sw:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants