New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AsciiOutputModule to print out alias branches, and extend EventContentAnalyzer to optionally print provenance information #25265
Conversation
The code-checks are being triggered in jenkins. |
@@ -472,6 +509,8 @@ namespace edm { | |||
np = desc.addOptionalUntracked<bool>("listContent", true); | |||
np->setComment("If true then print a list of all the event content."); | |||
|
|||
np = desc.addOptionalUntracked<bool>("listProvenance", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dr15Jones Is there a good reason for these to be optional, given that all of them have default values? Now the defaults are specified twice.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25265/7288 |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/Modules @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 cross-checked in a simple standalone test |
This PR includes two related changes for investigating in detail the provenance information of EDAlias products:
AsciiOutputModule
Event::getAllProvenance()
ignores alias branches, soAsciiOutputModule
ignores alias branches as well. In order to print those, IConstProductRegistry
insteadverbosity > 2
) print out the PSet of the module producing the branch (and in case of alias, of the module alias is for)EventContentAnalyzer
I added an option (
listProvenance
) to print out (event by event) provenance information for the branches.Tested in CMSSW_10_4_0_pre2, no changes expected.
@Dr15Jones