Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SeedingLayerSetsHits to TrackingTools/TransientTrackingRecHit package #2527

Merged
merged 1 commit into from Feb 22, 2014
Merged

Move SeedingLayerSetsHits to TrackingTools/TransientTrackingRecHit package #2527

merged 1 commit into from Feb 22, 2014

Conversation

makortel
Copy link
Contributor

As suggested by @davidlange6 in #2378 after the merge. Tested with runTheMatrix.py -l limited -i all.

@makortel
Move SeedingLayerSetsHits to TrackingTools/TransientTrackingRecHit
ea1def0 
In order to avoid a package with only one class. SeedingLayerSetsHits
can be thought as a very specialized container of
TransientTrackingRecHits.
@makortel makortel mentioned this pull request Feb 19, 2014
Merged
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_1_X.

Move SeedingLayerSetsHits to TrackingTools/TransientTrackingRecHit package

It involves the following packages:

RecoPixelVertexing/PixelTriplets
RecoTracker/SeedingLayerSetsHits
RecoTracker/TkHitPairs
RecoTracker/TkSeedGenerator
RecoTracker/TkSeedingLayers
RecoTracker/TkTrackingRegions
TrackingTools/TransientTrackingRecHit

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @cerati, @gpetruc, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2527/225/summary.html

@perrotta perrotta mentioned this pull request Feb 20, 2014
Closed
@slava77
Copy link
Contributor

slava77 commented Feb 21, 2014

+1

#2527 ea1def0

code ok
jenkins ok

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 22, 2014
@ktf
Merge pull request #2527 from makortel/moveSeedingLayerSetsHits
b3c47f0 
Reco cleanup -- Move SeedingLayerSetsHits to TrackingTools/TransientTrackingRecHit package
@ktf ktf merged commit b3c47f0 into cms-sw:CMSSW_7_1_X Feb 22, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
This was referenced Mar 5, 2014
Merged
Merged
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@makortel makortel deleted the moveSeedingLayerSetsHits branch October 20, 2016 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makortel @cmsbuild @slava77 @ktf @nclopezo