Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize L1Trigger/CSCTrackFinder modules #25305

Merged
merged 4 commits into from Nov 24, 2018
Merged

Modernize L1Trigger/CSCTrackFinder modules #25305

merged 4 commits into from Nov 24, 2018

Commits on Nov 20, 2018

  1. Hold CSCTFMuonSorter by value 

    Holding by value is more efficient and keeps const correctness.
    @Dr15Jones
    Dr15Jones committed Nov 20, 2018
    Copy the full SHA
    80f7e73 View commit details
    Browse the repository at this point in the history

  2. Modernized CSCTFCandidateProducer 

    -converted to a global module
-hold CSCTFCandidateBuilder by value to keep const correctness
-use EDPutToken
    @Dr15Jones
    Dr15Jones committed Nov 20, 2018
    Copy the full SHA
    a591879 View commit details
    Browse the repository at this point in the history

  3. Made static arrays in CSCTFPtMethods const

    @Dr15Jones
    Dr15Jones committed Nov 20, 2018
    Copy the full SHA
    2181ede View commit details
    Browse the repository at this point in the history

  4. Modernized CSCTFTrackProducer 

    -Made it a one module since it depends on thread-hostile code
-Used std::unique_ptr
-Avoided the use of pointer when by value would work
-Made member variables const when appropriate
    @Dr15Jones
    Dr15Jones committed Nov 20, 2018
    Copy the full SHA
    1d37274 View commit details
    Browse the repository at this point in the history