avoid divide by zero in HCAL status word DQM histograms

[kpedro88]

In the new 2023D35 workflow, there are no valid HE cells (replaced by HGCal). This caused a divide by zero problem in the HCAL status word DQM histograms, which showed up as a spurious failure in the comparison tests. It is fixed in this PR.

attn: @abdoulline, @DryRun

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25310/7338

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

DQMOffline/Hcal

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31781/console Started: 2018/11/21 04:20

[cmsbuild]

+1
Tested at: 60d0f59
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25310/31781/summary.html

[cmsbuild]

Comparison job queued.

[abdoulline]

@kpedro88 thank you, Kevin.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25310/31781/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013111
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[andrius-k]

Hi @kpedro88, will there be a back-port of this PR?

[kpedro88]

@andrius-k the D35 workflow is only present in 10_4_X, so I don't see the need for a backport

[andrius-k]

+1

@kpedro88 thanks for clarification.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1