Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[103X] Change GT. FIX CSC timing for 2016 and 2017 MC. New HIon L1T menu V4_2_0 for HIon #25321

Merged
merged 2 commits into from Nov 28, 2018

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Nov 22, 2018

. CSC MC timing fixed in 2016 and 2017 MC GTs.

. New HIon L1T menu V4_2_0 for HIon for:

Data
run2_hlt_relval_hi and
run2_data_promptlike_hi
MC
phase1_2018_realistic_hi

@lpernie
Copy link
Contributor Author

lpernie commented Nov 22, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31808/console Started: 2018/11/22 21:56

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2018

A new Pull Request was created by @lpernie (Luca Pernie) for CMSSW_10_3_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25321/31808/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 95 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3181535
  • DQMHistoTests: Total failures: 667
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3180671
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Nov 24, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Pull request #25321 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@lpernie
Copy link
Contributor Author

lpernie commented Nov 26, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31857/console Started: 2018/11/26 20:39

@lpernie lpernie changed the title [103X] Change GT. FIX CSC timing for 2016 and 2017 MC [103X] Change GT. FIX CSC timing for 2016 and 2017 MC. New HIon L1T menu V4_2_0 for HIon Nov 26, 2018
@lpernie
Copy link
Contributor Author

lpernie commented Nov 26, 2018

backport of #25322

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25321/31857/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 94 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3181535
  • DQMHistoTests: Total failures: 667
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3180671
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.164 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 158.0 ): -0.164 KiB L1T/L1TStage2uGT
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Nov 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9da8793 into cms-sw:CMSSW_10_3_X Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants