[10_3_X] Strip packer: protect against invalid header types

[pieterdavid]

Backport of #25331

CC: @icali @stahlleiton @CesarBernardes @erikbutz @mmusich

[cmsbuild]

A new Pull Request was created by @pieterdavid (Pieter David) for CMSSW_10_3_X.

It involves the following packages:

EventFilter/SiStripRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Strip packer: protect against invalid header types #25331

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31838/console Started: 2018/11/25 08:10

[fabiocos]

@pieterdavid @perrotta I have merged the master version, but if the fix is needed for production urgently we will need a 10_3_X patch with this backport inside

[cmsbuild]

+1
Tested at: b109fd2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25332/31838/summary.html

[cmsbuild]

Comparison job queued.

[icali]

Hi @fabiocos ,
yes, we would like indeed to ask for a patch release with this PR included.
It would fix the HLT errors that we see now. Also if we are speaking of only few 100s events. We see that the merging timing is affected by failing jobs.

If you agree to provide a patch release shortly, we could ask for a replay and target to have it online in already at the beginning of the week.
Please let me know what you think being feasible/reasonable,
Cheers,
Ivan

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25332/31838/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3181535
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3181337
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• The fix adds the protection as announced in the PR description
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1