make Constrain Hits first class citizen

[VinInn]

This PR makes Transient Constrain Hits "first class citizen" so that they can be used in standard fits and pattern recognition.
Possible applications of the 5D Constrain can be to represent a "tracklet" (a seed for instance) to be used "asis" during CKF (think of L1 trackless or pixelTrack from FPGA or GPU) .
2D Constrains can be used as "Frozen Hits" w/o any further reference to clusters.

As the required mods touch very basic packages, here is a purely technical PR w/o ay further infrastructure to try/test any of the use case above.
This will allow further development w/o the need of recompiling half of the universe.

purely technical NO regression expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25333/7358

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

DQM/SiPixelPhase1Track
DataFormats/TrackerRecHit2D
RecoLocalTracker/SubCollectionProducers
RecoTracker/CkfPattern
RecoTracker/DeDx
RecoTracker/FinalTrackSelectors
RecoTracker/TrackProducer
RecoTracker/TransientTrackingRecHit
SimTracker/TrackAssociation
TrackingTools/GsfTracking
TrackingTools/PatternTools

@perrotta, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @forthommel, @yduhm, @alesaggio, @fioriNTU, @abbiendi, @mmusich, @hdelanno, @battibass, @makortel, @threus, @jhgoh, @HuguesBrun, @trocino, @pieterdavid, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @jandrea, @mschrode, @idebruyn, @ebrondol, @dgulhan, @gbenelli, @calderona, @gpetruc, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[VinInn]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31837/console Started: 2018/11/24 19:17

[cmsbuild]

-1

Tested at: e980a8e

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
82e7b5c
4d8dfdd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25333/31837/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25333/31837/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25333/31837/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testSSTGainPCL_fromRECO had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
82e7b5c
4d8dfdd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25333/31837/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25333/31837/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25333/32027/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3131939
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3131733
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

why this header stuff is not run in the code-checks?

@smuzaffar
should we at add it to the cms-bot summary message on github?
Current path of detection is to notice it in the summary.html in the test results

[smuzaffar]

@VinInn, for code-checks we only need PR changes and it is quick to run to give fast feedback to L2s. For header checks we need to rebuild all packages which are affected by the change and takes much more time to run. Also frequency of getting internal compiler (ICE) errors is very high for header checks that is why we do not run them at code-checks time and also currently cms-bot does not mark PR tests failed based on the results of header checks (due to high frequency of ICE).

[slava77]

+1

for #25333 15e5f1b

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no differences as expected.

It looks like a possible conflict with the "future" MTD changes can be easily resolved.

[civanch]

+1

[andrius-k]

+1

[slava77]

@kpedro88
please check and sign this if it's OK to go in now (I added the upgrade signature due to an apparent overlap with MTD).

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

@fabiocos
please clarify why this is still not merged

[fabiocos]

+1

@slava77 @kpedro88 @lgray this will trigger a conflict in #25063, but as far as I can see it should be simple to adjust