Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --harvesting AtJobEnd option in GEN Relval workflows #25339

Merged
merged 1 commit into from Nov 28, 2018

Conversation

SanghyunKo
Copy link
Contributor

In recent 10_4_0_pre2 release validation campaign, DQMIO files of ALL GEN Relval samples were not uploaded to DQM server due to the wrong run number (999999). This was caused by PR #24920 , the dummy run number parameter of all GEN workflows was affected by the change introduced in DQMSaverAtJobEnd_cff.py because all GEN Relval workflows were using '--harvesting AtJobEnd' option. Since there is no point of using '--harvesting AtJobEnd' option (there is only single harvesting job like any other Relval workflows), simply removing this option can fix the issue.

Fix the issue #25272 . See JIRA ticket 4020 for detailed discussions.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SanghyunKo (Sanghyun Ko) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@zhenhu
Copy link
Contributor

zhenhu commented Nov 26, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31850/console Started: 2018/11/26 16:03

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25339/31850/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131633
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented Nov 26, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Nov 27, 2018

@zhenhu I understand that there is no foreseen drawback by this fix, and it is not even clear from the discussion why this option was used in first place

@kpedro88 this is not upgrade specific, anyway please check and sign it

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

GEN workflows correctly produce DQM output in standalone test runs producing as output
DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root

@cmsbuild cmsbuild merged commit 9e9a9fc into cms-sw:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants