DD4hep: Add Reflection Rotation #25345
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25345/7366 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
|
||
| double tol = 1.0e-3; // Geant4 compatible | ||
| double check = ( x.Cross( y )).Dot( z ); // in case of a LEFT-handed orthogonal system this must be -1 | ||
| if( fabs( 1. + check ) > tol ) { |
There was a problem hiding this comment.
I think we should be using std::abs not fabs.
| DD3Vector y( cos( phiY ) * sin( thetaY ), sin( phiY ) * sin( thetaY ), cos( thetaY )); | ||
| DD3Vector z( cos( phiZ ) * sin( thetaZ ), sin( phiZ ) * sin( thetaZ ), cos( thetaZ )); | ||
|
|
||
| double tol = 1.0e-3; // Geant4 compatible |
|
@cvuosalo - thanks! I'll integrate the code corrections in the next PR. |
*) See the note about Trd1