Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_2_X] Egamma Fall17 V2 Photon ID #25347

Closed
wants to merge 6 commits into from
Closed

[10_2_X] Egamma Fall17 V2 Photon ID #25347

wants to merge 6 commits into from

Conversation

guitargeek
Copy link
Contributor

Backport of #25293 plus changes to make Photon MVA V2 work before #24131 and adapting to new weights files names.

Has to be tested with cms-sw/cmsdist#4518

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for CMSSW_10_2_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoEgamma/PhotonIdentification

@perrotta, @monttj, @cmsbuild, @fgolf, @slava77, @peruzzim can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @jainshilpi, @rappoccio, @HeinerTholen, @varuns23, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @lgray, @jdolen, @drkovalskyi, @ferencek, @Sam-Harper, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@guitargeek guitargeek changed the title [10_2_X] Egamma Fall17 V2 Photon IDso [10_2_X] Egamma Fall17 V2 Photon ID Nov 26, 2018
@perrotta
Copy link
Contributor

@cmsbuild please test with cms-sw/cmsdist#4518

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2018

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4518
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31866/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25347/31866/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 330 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007299
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007107
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Dec 3, 2018

-1

@guitargeek
Copy link
Contributor Author

Yep, closed.

@guitargeek guitargeek closed this Dec 4, 2018
@guitargeek guitargeek deleted the PhotonID_10_2_X_ID_only branch December 12, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants