Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation/Geometry: CleanUp #25381

Merged
merged 1 commit into from Dec 4, 2018
Merged

Validation/Geometry: CleanUp #25381

merged 1 commit into from Dec 4, 2018

Conversation

vargasa
Copy link
Contributor

@vargasa vargasa commented Nov 29, 2018

Removing old _cfg files. Functionality has been integrated into runP_Tracker_cfg.py:

	for t in {'BeamPipe','Tracker','PixBar','PixFwdMinus','PixFwdPlus', \
	'TIB','TOB','TIDB','TIDF','TEC','TkStrct','InnerServices'}; \
	do cmsRun runP_Tracker_cfg.py geom=XYZ label=$t; done

Read: #17210

	Removing old _cfg files. Functionality has been integrated into
	runP_Tracker_cfg.py:

	for t in {'BeamPipe','Tracker','PixBar','PixFwdMinus','PixFwdPlus', \
	'TIB','TOB','TIDB','TIDF','TEC','TkStrct','InnerServices'}; \
	do cmsRun runP_Tracker_cfg.py geom=XYZ label=$t; done

	Read: cms-sw#17210
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

Validation/Geometry

@andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @civanch can you please review it and eventually sign? Thanks.
@rishabhCMS, @rovere, @rbartek this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31918/console Started: 2018/11/30 14:33

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25381/31918/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131634
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@cvuosalo
Copy link
Contributor

+1

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 4, 2018

+1

@cmsbuild cmsbuild merged commit f44a319 into cms-sw:master Dec 4, 2018
@vargasa vargasa deleted the CleanUp branch December 7, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants