Added 2018 PbPb collision vertex smearing parameters #25390

ColeLindsey · 2018-11-30T21:05:04Z

Added in vertex smearing parameters from the 2018 PbPb collision. More detailed presentation can be seen at:

https://cernbox.cern.ch/index.php/s/J3Emh3kw0Y3EGmf

cmsbuild · 2018-11-30T21:05:23Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-11-30T21:17:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25390/7425

cmsbuild · 2018-11-30T21:17:52Z

A new Pull Request was created by @ColeLindsey for master.

It involves the following packages:

Configuration/StandardSequences
IOMC/EventVertexGenerators

@civanch, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

lpernie · 2018-11-30T21:30:49Z

please test

cmsbuild · 2018-11-30T21:31:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31928/console Started: 2018/11/30 22:31

lpernie · 2018-11-30T21:31:40Z

Configuration/StandardSequences/python/VtxSmeared.py

@@ -58,7 +58,7 @@
    'Realistic100ns13TeVCollisionBetaStar90mLowBunches' : 'IOMC.EventVertexGenerators.VtxSmearedRealistic100ns13TeVCollisionBetaStar90mLowBunches_cfi',
    'Realistic25ns13TeVEarly2017Collision' : 'IOMC.EventVertexGenerators.VtxSmearedRealistic25ns13TeVEarly2017Collision_cfi',
    'Realistic25ns13TeVEarly2018Collision' : 'IOMC.EventVertexGenerators.VtxSmearedRealistic25ns13TeVEarly2018Collision_cfi',
-
+    'RealisticPbPbCollision2018' : 'IOMC.EventVertexGenerators.VtxSmearedRealisticPbPbCollision2018_cfi.py',


Should be _cfi, ad in the lines above

cmsbuild · 2018-12-01T00:06:56Z

+1
Tested at: 352805a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25390/31928/summary.html

cmsbuild · 2018-12-01T00:06:58Z

Comparison job queued.

cmsbuild · 2018-12-01T02:02:23Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25390/31928/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3131839
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3131634
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

mmusich · 2018-12-01T16:31:03Z

IOMC/EventVertexGenerators/python/VtxSmearedParameters_cfi.py

@@ -713,6 +713,19 @@
    Z0 = cms.double(0.645)
 )

+# From fit to 5 TeV PbPb data


@ColeLindsey it is considered good practice to document in this file how the numbers reported in the configuration have been obtained by breaking down the contribution from the Beam Spot and the pixel barycenter positions.
You might refer to this:

cmssw/IOMC/EventVertexGenerators/python/VtxSmearedParameters_cfi.py

Lines 597 to 612 in f084ec0

# From 2018B 3.8T data

# BS parameters extracted from run 316199, fill 6675 (from StreamExpressAlignment, HP BS):

# X0 = 0.09676 [cm]

# Y0 = -0.06245 [cm]

# Z0 = -0.292 [cm]

# sigmaZ0 = 3.5 [cm] => mean sigmaZ0 in this run is 3.2676

# BeamWidthX 0.0008050

# BeamWidthY 0.0006238

#

# From LHC calculator, emittance is 1.634e-8 cm

# https://lpc.web.cern.ch/lpc/lumi2.html

#

# BPIX absolute position (from https://cms-conddb.cern.ch/cmsDbBrowser/payload_inspector/Prod):

# X = 0.0859918 cm

# Y = -0.104172 cm

# Z = -0.327748 cm

as a good example.

tocheng · 2018-12-03T10:23:23Z

@ColeLindsey
Could you please update the PR based on @lpernie and @mmusich 's comments?
Thanks!

cmsbuild · 2018-12-03T22:20:06Z

Pull request #25390 was updated. @civanch, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

ColeLindsey · 2018-12-03T22:24:43Z

Sorry! I wasn't familiar with how to update my PR so I hadn't pushed the changes until now. Thank you all

civanch · 2018-12-05T13:32:32Z

please test

cmsbuild · 2018-12-05T13:32:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32006/console Started: 2018/12/05 14:33

cmsbuild · 2018-12-05T14:59:09Z

+1
Tested at: 8f88316
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25390/32006/summary.html

cmsbuild · 2018-12-05T14:59:13Z

Comparison job queued.

cmsbuild · 2018-12-05T16:43:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25390/32006/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3131939
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3131734
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

civanch · 2018-12-06T09:37:38Z

+1

fabiocos · 2018-12-06T10:34:19Z

+operations

addition of a new beam spot scenario, no change to the previous ones

cmsbuild · 2018-12-06T10:34:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-12-06T10:35:05Z

+1

Added 2018 PbPb collision vertex smearing parameters

Added 2018 PbPb collision vertex smearing parameters

352805a

cmsbuild added this to the CMSSW_10_4_X milestone Nov 30, 2018

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pending-signatures simulation-pending tests-pending labels Nov 30, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 30, 2018

cmsbuild added tests-started and removed tests-pending labels Nov 30, 2018

lpernie reviewed Nov 30, 2018

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Dec 1, 2018

cmsbuild added comparison-available and removed comparison-pending labels Dec 1, 2018

mmusich reviewed Dec 1, 2018

View reviewed changes

Removed extra .py and added more information about smearing parameters

8f88316

cmsbuild removed the code-checks-approved label Dec 3, 2018

ColeLindsey mentioned this pull request Dec 4, 2018

Backport of 2018 PbPb vertex smearing parameters #25419

Merged

cmsbuild added tests-started and removed tests-pending labels Dec 5, 2018

cmsbuild added tests-approved and removed tests-started labels Dec 5, 2018

cmsbuild added comparison-available and removed comparison-pending labels Dec 5, 2018

cmsbuild added simulation-approved and removed simulation-pending labels Dec 6, 2018

cmsbuild added fully-signed operations-approved and removed operations-pending pending-signatures labels Dec 6, 2018

cmsbuild added orp-approved and removed orp-pending labels Dec 6, 2018

cmsbuild merged commit 8b204e4 into cms-sw:master Dec 6, 2018

ColeLindsey mentioned this pull request Dec 9, 2018

Changed default HI vertex smearing parameter to 2018 PbPb #25456

Closed

forthommel pushed a commit to forthommel/cmssw that referenced this pull request Dec 10, 2018

Merge pull request cms-sw#25390 from ColeLindsey/vertexSmearingPbPb

c3d778a

Added 2018 PbPb collision vertex smearing parameters

fabiocos mentioned this pull request Dec 11, 2018

Fix the forgotten new default for 2018 HI vertex smearing (as in 10_3_X) #25474

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added 2018 PbPb collision vertex smearing parameters #25390

Added 2018 PbPb collision vertex smearing parameters #25390

ColeLindsey commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

lpernie commented Nov 30, 2018

cmsbuild commented Nov 30, 2018 •

edited

lpernie Nov 30, 2018

cmsbuild commented Dec 1, 2018

cmsbuild commented Dec 1, 2018

cmsbuild commented Dec 1, 2018

mmusich Dec 1, 2018

tocheng commented Dec 3, 2018

cmsbuild commented Dec 3, 2018

ColeLindsey commented Dec 3, 2018

civanch commented Dec 5, 2018

cmsbuild commented Dec 5, 2018 •

edited

cmsbuild commented Dec 5, 2018

cmsbuild commented Dec 5, 2018

cmsbuild commented Dec 5, 2018

civanch commented Dec 6, 2018

fabiocos commented Dec 6, 2018

cmsbuild commented Dec 6, 2018

fabiocos commented Dec 6, 2018

	# From 2018B 3.8T data
	# BS parameters extracted from run 316199, fill 6675 (from StreamExpressAlignment, HP BS):
	# X0 = 0.09676 [cm]
	# Y0 = -0.06245 [cm]
	# Z0 = -0.292 [cm]
	# sigmaZ0 = 3.5 [cm] => mean sigmaZ0 in this run is 3.2676
	# BeamWidthX 0.0008050
	# BeamWidthY 0.0006238
	#
	# From LHC calculator, emittance is 1.634e-8 cm
	# https://lpc.web.cern.ch/lpc/lumi2.html
	#
	# BPIX absolute position (from https://cms-conddb.cern.ch/cmsDbBrowser/payload_inspector/Prod):
	# X = 0.0859918 cm
	# Y = -0.104172 cm
	# Z = -0.327748 cm

Added 2018 PbPb collision vertex smearing parameters #25390

Added 2018 PbPb collision vertex smearing parameters #25390

Conversation

ColeLindsey commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

lpernie commented Nov 30, 2018

cmsbuild commented Nov 30, 2018 • edited

lpernie Nov 30, 2018

Choose a reason for hiding this comment

cmsbuild commented Dec 1, 2018

cmsbuild commented Dec 1, 2018

cmsbuild commented Dec 1, 2018

mmusich Dec 1, 2018

Choose a reason for hiding this comment

tocheng commented Dec 3, 2018

cmsbuild commented Dec 3, 2018

ColeLindsey commented Dec 3, 2018

civanch commented Dec 5, 2018

cmsbuild commented Dec 5, 2018 • edited

cmsbuild commented Dec 5, 2018

cmsbuild commented Dec 5, 2018

cmsbuild commented Dec 5, 2018

civanch commented Dec 6, 2018

fabiocos commented Dec 6, 2018

cmsbuild commented Dec 6, 2018

fabiocos commented Dec 6, 2018

cmsbuild commented Nov 30, 2018 •

edited

cmsbuild commented Dec 5, 2018 •

edited