Sim magnetic field

[civanch]

Clean-up and extension of magnetic field for simulation:

1. added possibility to use a special set of parameters for integration in magnetic field in set of geometry regions;
2. fixed problem in initialisation printouts;
3. defined chord finder parameters in one place of the code;
4. clean-up simulation of monopole transportation in field;
5. removed unused headers and obsolete comments, added improved comments.

No change in results is expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25401/7443

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/MagneticField
SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @namapane this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31954/console Started: 2018/12/03 19:54

[cmsbuild]

+1
Tested at: 184e2e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25401/31954/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25401/31954/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3131839
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3131633
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

@fabiocos , this PR is only addition and technical cleanup. Such type of PRs are valid is no change is observed in regression tests.

[fabiocos]

@civanch indeed the test does not show any difference, so we could merge it. At some point anyway we will need a larger scale test, and as we have been already reproduced the GEN-SIM in pre3 I would like to avoid redoing them multiple times in a row.

[fabiocos]

+1