Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended HLT menus (pp and PbPb) for MC production (103X) #25414

Merged
merged 4 commits into from Dec 11, 2018

Conversation

Martin-Grunewald
Copy link
Contributor

Extended HLT menus (pp and PbPb) for MC production (103X)
Based on CMSSW_10_3_X_2018-12-01-1100

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_10_3_X.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration
Utilities/ReleaseScripts

@Martin-Grunewald, @smuzaffar, @cmsbuild, @Dr15Jones, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #25413

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31970/console Started: 2018/12/04 12:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

Pull request #25414 was updated. @Martin-Grunewald, @smuzaffar, @cmsbuild, @Dr15Jones, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

Pull request #25414 was updated. @Martin-Grunewald, @smuzaffar, @cmsbuild, @Dr15Jones, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31988/console Started: 2018/12/04 15:35

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25414/31988/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3181311
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 14
  • DQMHistoTests: Total successes: 3181054
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1395.36 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 250202.181,... ): 459.270 KiB HLT/TAU
  • DQMHistoSizes: changed ( 250202.181,... ): 35.174 KiB HLT/Objects
  • DQMHistoSizes: changed ( 250202.181,... ): 0.702 KiB HLT/GeneralHLTOffline
  • DQMHistoSizes: changed ( 136.85,... ): 184.245 KiB HLT/TAU
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones
Please sign for core (addOnTests)

@Dr15Jones
Copy link
Contributor

+1
hlt configurations were moved out of addOnTests.py to a new file

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cb64851 into cms-sw:CMSSW_10_3_X Dec 11, 2018
@Martin-Grunewald Martin-Grunewald deleted the HLTmenusGRunHIon103X branch October 27, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants