New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed clang warnings in L1Trigger/L1THGCal #25429
Conversation
This fixes a clang warning.
These were found by clang.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25429/7487 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: L1Trigger/L1THGCal @nsmith-, @rekovic, @cmsbuild, @thomreis, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Hi @kpedro88 |
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@jbsauvan sorry do you mean "still" or do you mean "no more"? Is there a plan to use them, is this that you mean? Or are they just obsolete pieces of code to drop as @Dr15Jones suggests? |
Hi @fabiocos, I mean "still" in the sense that they have never been used. Part of this |
@jbsauvan ok, so if and when they will be needed they will enter again |
+1 |
Fixed clang warnings in L1Trigger/L1THGCal
-A struct was being forward declared as a class.
-There were unused file scoped variables and functions.