Additional crystals added to the EcalBadCal MET filter

[lathomas]

New hot EE crystals have been recently observed in 2017 and 2018.
After discussion between ECAL and JME it was decided to add them to the list of crystal considered by the ecal bad calibration MET filter.

More information here:
https://indico.cern.ch/event/775564/contributions/3239371/attachments/1765837/2866952/ecalbadcalfilterupdate.pdf
https://twiki.cern.ch/twiki/bin/viewauth/CMS/MissingETOptionalFiltersRun2#How_to_run_ecal_BadCalibReducedM

@ahinzmann @peruzzim @eioannou @zdemirag

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25436/7501

[cmsbuild]

A new Pull Request was created by @lathomas for master.

It involves the following packages:

RecoMET/METFilters

@perrotta, @monttj, @cmsbuild, @fgolf, @slava77, @peruzzim can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[peruzzim]

Please ask for advice and agree on how to extend the crystal list also in view of backport to 10_2_X, where you will not be allowed to just extend it like that because it would change the content of miniAOD.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32036/console Started: 2018/12/06 15:00

[cmsbuild]

The code-checks are being triggered in jenkins.

[lathomas]

@peruzzim I updated the config file and added a new instance of the filter to be run on MINIAOD.
From what I understand this can be safely backported to 102X and 94X. Can you confirm this is fine?
If yes I'll open the PR.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25436/7505

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25436/7544

[cmsbuild]

Pull request #25436 was updated. @perrotta, @monttj, @cmsbuild, @fgolf, @slava77, @peruzzim can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32095/console Started: 2018/12/10 15:47

[cmsbuild]

+1
Tested at: 550b24f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25436/32095/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25436/32095/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3136422
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3136217
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #25436 550b24f

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no differences [some may be expected in the Flag_ecalBadCalibFilter decision, but the number of tested events is not that large to certainly expect a visible change]

[fabiocos]

+1

[fabiocos]

merge