TkAl: making mille job submission via condor possible #25437
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25437/7503 |
|
A new Pull Request was created by @adewit for master. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@adewit Do you manage to implement the improvement in the note soon? |
|
@pohsun No, I don't think I'll be able to do it soon (that's why I already made the PR). If there are objections to merging this now we can wait, but it certainly won't come this year anymore. |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@adewit this is not breaking anything in the release as far as I can see, but was it tested? |
|
@fabiocos Yes, it was tested and has the expected behaviour. |
|
+1 |
This adds the functionality to submit all parts of the MillePede alignment algorithm to condor (in preparation of LSF-CAF decommissioning). For now LSF submission is still the default, but condor submission is fully supported.
Note that the submission could be made more efficient, as at the moment now we submit one job per cluster - submitting multiple jobs per cluster requires some overhaul of the current workflow. I have some ideas but this will take a bit more time to get right, and so will follow later.