New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extra Physics Lists for neutron background study #25438
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25438/7507 |
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/PhysicsLists @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@civanch were these lists minimally tested in a standalone way? Obviously this PR test just shows they compile... |
@fabiocos , they are tested by Geant4 team - no extra hadronic component is added from us, EMM is our production variant for electromagnetic physics. FTFP_BERT_HP is the Geant4 default for high precision neutrons, we already have FTFP_BERT_HP_EML, now FTFP_BERT_HP_EMM is added. All these is well tested. |
@civanch in between the detailed physics validation done by Geant4 (of the model but not of the CMSSW interface proposed here) and that can be redone once this code is available, and the mere fact that this code compiles, there is a cmsRun with a modified physics list showing that this code runs on some events without crashing/doing anything odd. Was this done by you? I assume yes, I just would like to have a confirmation about it. |
@fabiocos , I run 100 MinBias events for each Physics LIst - no problem observed , except the fact that all these new Physics Lists are substantially slower the CMS default, but this is expected. |
@civanch ok thanks |
+1 |
Added extra Physics Lists for neutron background study
For neutron background study 3 new Physics Lists are added: FTFP_BERT_HP_EMM, FTFP_INCLXX_EMM, and FTFP_INCLXX_HP_EMM. Should not affect mainstream production.