Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra Physics Lists for neutron background study #25438

Merged
merged 1 commit into from Dec 7, 2018

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Dec 6, 2018

For neutron background study 3 new Physics Lists are added: FTFP_BERT_HP_EMM, FTFP_INCLXX_EMM, and FTFP_INCLXX_HP_EMM. Should not affect mainstream production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Dec 6, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32042/console Started: 2018/12/06 19:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25438/32042/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3136422
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3136217
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Dec 6, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 7, 2018

@civanch were these lists minimally tested in a standalone way? Obviously this PR test just shows they compile...

@civanch
Copy link
Contributor Author

civanch commented Dec 7, 2018

@fabiocos , they are tested by Geant4 team - no extra hadronic component is added from us, EMM is our production variant for electromagnetic physics. FTFP_BERT_HP is the Geant4 default for high precision neutrons, we already have FTFP_BERT_HP_EML, now FTFP_BERT_HP_EMM is added. All these is well tested.
FTFP_INCLXX and FTFP_INCLXX_HP are used not so frequently and there are known advantages and concerns to use INCLXX cascade model. In past, I tried to avoid include them as CMSSW options but Sergio several times ask about such possibility for neutron background study. I think, that if a physics list is available in Geant4 distribution, then we can provide a possibility to CMS users try it out if there is a request.

@fabiocos
Copy link
Contributor

fabiocos commented Dec 7, 2018

@civanch in between the detailed physics validation done by Geant4 (of the model but not of the CMSSW interface proposed here) and that can be redone once this code is available, and the mere fact that this code compiles, there is a cmsRun with a modified physics list showing that this code runs on some events without crashing/doing anything odd. Was this done by you? I assume yes, I just would like to have a confirmation about it.

@civanch
Copy link
Contributor Author

civanch commented Dec 7, 2018

@fabiocos , I run 100 MinBias events for each Physics LIst - no problem observed , except the fact that all these new Physics Lists are substantially slower the CMS default, but this is expected.

@fabiocos
Copy link
Contributor

fabiocos commented Dec 7, 2018

@civanch ok thanks

@fabiocos
Copy link
Contributor

fabiocos commented Dec 7, 2018

+1

@cmsbuild cmsbuild merged commit 5b3b317 into cms-sw:master Dec 7, 2018
forthommel pushed a commit to forthommel/cmssw that referenced this pull request Dec 10, 2018
Added extra Physics Lists for neutron background study
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants