Increment version number of AssociationVector template #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_1_X. Increment version number of AssociationVector template It involves the following packages: DataFormats/Common @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
Merging this skipping tests since I trust Bill (and this rebuilds everything). |
ktf
added a commit
that referenced
this pull request
Feb 19, 2014
Framework fixes -- Increment version number of AssociationVector template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull request #2434, already merged, a bug was fixed where the transientVector_ data member of the AssociationVector template was not declared transient in the dictionary specification of one instance of this template, although it should have been. That pull request fixed a ROOT6 error.
Since this was just one instance of a template, there is no declared ROOT version number associated with the instance. Rather, there is a version number for the entire template. That version number should have been incremented in #2434, because making a member transient affects the checksum, but was not. This pull request increments the ROOT version of the template. This fixes the fatal exception seen by Vincenzo Innocente when reading a file containing the older version of the class.