Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkAlInOneTool: optional muon pT cut and set default eta ranges in Zmm validation #25442

Merged
merged 2 commits into from Dec 16, 2018

Conversation

adewit
Copy link
Contributor

@adewit adewit commented Dec 7, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

A new Pull Request was created by @adewit for master.

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

Pull request #25442 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@fabiocos
Copy link
Contributor

fabiocos commented Dec 7, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32071/console Started: 2018/12/07 21:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25442/32071/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3136422
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3136216
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #25442 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@kpedro88
Copy link
Contributor

@adewit for future reference, you can specify --old-base in cms-rebase-topic to select only a few commits to rebase (where --old-base is the hash of the last commit before your changes). This is described in the page I linked.

@pohsun
Copy link

pohsun commented Dec 13, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32174/console Started: 2018/12/13 15:31

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25442/32174/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3136422
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3136217
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e7a0380 into cms-sw:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants