Clean-up Geant4 sensitive detectors 7

[civanch]

In this PR only simple technical clean-up of base classes of Geant4 sensitive detectors (SD) is proposed. The correctness of this PR corresponds to "no change" in comparisons. What was improved:

1. removed remaining auto_ptr
2. removed unused dependence of SD from DDDWorld, only DDCompactView is used
3. removed remaining dependences from SD sub-libraries on SimG4Core/Application (potential circular dependence)
4. use more forward declarations, removed unused includes
5. improved verbose output
6. removed analysis objects from SD classes
7. followed CMSSW code guidelines

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25504/7660

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4CMS/CherenkovAnalysis
SimG4CMS/HcalTestBeam
SimG4Core/Application
SimG4Core/Geometry
SimG4Core/GeometryProducer
SimG4Core/SensitiveDetector

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32220/console Started: 2018/12/15 21:30

[cmsbuild]

+1
Tested at: 00f6112
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25504/32220/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25504/32220/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153505
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[civanch]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25504/7673

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32238/console Started: 2018/12/17 20:23

[cmsbuild]

Pull request #25504 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[cmsbuild]

+1
Tested at: 1df13fa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25504/32238/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25504/32238/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153505
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

DQM changes look unrelated