Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward declare DetLayer as a class not struct #25519

Merged
merged 1 commit into from Jan 8, 2019
Merged

Forward declare DetLayer as a class not struct #25519

merged 1 commit into from Jan 8, 2019

Conversation

Dr15Jones
Copy link
Contributor

This fixes a clang warning.

@cmsbuild cmsbuild added this to the CMSSW_10_4_X milestone Dec 19, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25519/7710

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 19, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32273/console Started: 2018/12/19 15:47

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

HLTriggerOffline/Muon

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @trocino, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 42c0cfb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25519/32273/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25519/32273/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153512
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar smuzaffar modified the milestones: CMSSW_10_4_X, CMSSW_10_5_X Dec 20, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Jan 7, 2019

@andrius-k @schneiml could you please check and comment or sign? The update seems quite simple.

@fabiocos
Copy link
Contributor

fabiocos commented Jan 7, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32424/console Started: 2019/01/07 13:16

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2019

+1
Tested at: 42c0cfb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25519/32424/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25519/32424/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153512
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jan 8, 2019

+1

@cmsbuild cmsbuild merged commit 5c8de5c into cms-sw:master Jan 8, 2019
@Dr15Jones Dr15Jones deleted the structToclassDetLayer branch January 11, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_5_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Dr15Jones @cmsbuild @fabiocos @andrius-k @smuzaffar