Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoVertex/MultiVertexFit: clean -Wunused-function warnings #2556

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Feb 20, 2014

Cleans GCC 4.9.0 -Wunused-function warnings.

Also in RecoVertex/MultiVertexFit/src/MultiVertexReconstructor.cc there is a method inline void remove (...), which uses std::cout. Maybe that should be converted?

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_1_X.

RecoVertex/MultiVertexFit: clean -Wunused-function warnings

It involves the following packages:

RecoVertex/MultiVertexFit

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor

ktf commented Feb 20, 2014

It's in a .cc in any case, so it should not harm.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 21, 2014

+1

for #2556 5212985

based on just the code diff and the fact that jenkins compiled this and ran it fine.

.. where are the comparisons though? "Still running ..." appears to be a frequent issue

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 21, 2014
…x-MultiVertexFit

GCC 4.9.0 -- RecoVertex/MultiVertexFit: clean -Wunused-function warnings
@ktf ktf merged commit 157af33 into cms-sw:CMSSW_7_1_X Feb 21, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Merge pull request cms-sw#2556 from xjanssen/IB/CMSSW_8_1_X/gcc530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants