Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix introspection of C array data members #2666

Merged
merged 4 commits into from Feb 27, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 27, 2014

This pull request is fixes for three different problems involving C array data members, plus a unit test that would have found one of the problems. These problems all caused failures in conditions code in many relval tests in the ROOT6 branch.

1)MemberWithDict::typeof(), when the member is a C array, stripped off the array information and just returned the underlying type. The array information should not have been stripped.

  1. A framework unit test is added here that would have found the above problem.

  2. TypeID::className() put a space between the base type name and the opening square bracket. This is incompatible with the naming used by conditions.

  3. In the ROOT6 specific code in CondCore/ORA, the C array information was not stripped off in several places where it should have been. This pull request strips it off when needed,

Note: Items 1, 2, and 3 are not ROOT6 specific. The fixes and tests there will be back ported to 7_1_X.
Item 1 may be backported further if offline management wants it.

Please merge this in the ROOT6 branch promptly unless there are issues.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Fix introspection of C array data members

It involves the following packages:

CondCore/ORA
DataFormats/Common
DataFormats/TestObjects
FWCore/Utilities

@apfeiffer1, @Dr15Jones, @cmsbuild, @nclopezo, @ggovi, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request Feb 27, 2014
ROOT6 -- Fix introspection of C array data members
@ktf ktf merged commit c76cae4 into cms-sw:CMSSW_7_1_ROOT6_X Feb 27, 2014
@wmtan wmtan deleted the FixCArrayDataMembers branch February 27, 2014 22:11
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Merge pull request cms-sw#2556 from xjanssen/IB/CMSSW_8_1_X/gcc530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants