[10.5.X][UPGRADE_L1] Fix deps to resolve undefined reference mentioned in UBSAN IBS

[smuzaffar]

To resolve

  tmp/slc7_amd64_gcc700/src/L1Trigger/L1THGCal/src/L1TriggerL1THGCal/HGCalTriggerTools.cc.o:(.data.rel+0x458): undefined reference to `typeinfo for HcalGeometry'
   tmp/slc7_amd64_gcc700/src/L1Trigger/L1THGCal/src/L1TriggerL1THGCal/HGCalTriggerTools.cc.o:(.data.rel+0x498): undefined reference to `typeinfo for HcalGeometry'

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25563/7791

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

L1Trigger/L1THGCal

@nsmith-, @rekovic, @cmsbuild, @thomreis, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @jbsauvan, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32360/console Started: 2018/12/22 12:06

[cmsbuild]

+1
Tested at: c9db74a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25563/32360/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25563/32360/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153511
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[kpedro88]

+upgrade

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25563/7884

• This PR adds an extra 12KB to repository

[fabiocos]

@rekovic as now @thomreis is no more in the list of the authorized persons the l1 signature appears to be mising, even if the package was effectively signed. In case you may sign it, anyway I will keep the ok of Thomas for good and I will merge the package for tonight's IB

[fabiocos]

+1

[fabiocos]

merge