Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN related PR: Updating configs in Configuration/Generator/python/ with new gridpacks to fix errors (ref. PR 25343) #25571

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Saptaparna
Copy link
Contributor

@Saptaparna Saptaparna commented Dec 30, 2018

This PR is a response to PR #25343 (#25343). The gen related configs have been updated with new gridpacks that should solve the issues encountered in sl7 setup.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Saptaparna (Saptaparna Bhattacharya) for master.

It involves the following packages:

Configuration/Generator

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@alberto-sanchez
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 30, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32385/console Started: 2018/12/30 06:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25571/32385/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153512
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@Saptaparna
Copy link
Contributor Author

@alberto-sanchez is this PR okay? If there are no other issues, can this be merged? thanks!

@alberto-sanchez
Copy link
Member

please test workflow 523.0, 551.0, 555.0, 1360.0, 25210.0

@alberto-sanchez
Copy link
Member

@Saptaparna I am relaunching the test with the appropriate workflows. I missed those in the first try.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32388/console Started: 2018/12/31 05:17

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25571/32388/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153500
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@Saptaparna
Copy link
Contributor Author

@alberto-sanchez Is this PR fine? Looks like everything works, right?

@qliphy
Copy link
Contributor

qliphy commented Jan 3, 2019

Thanks @Saptaparna ! local tests with wf 551 and 555 look good to me.

@qliphy
Copy link
Contributor

qliphy commented Jan 3, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

kpedro88 commented Jan 3, 2019

+1

@cmsbuild cmsbuild merged commit 4fdeedc into cms-sw:master Jan 3, 2019
smuzaffar added a commit that referenced this pull request Jan 4, 2019
GEN related PR: Updating configs in Configuration/Generator/python/ with new gridpacks to fix errors (ref. PR 25343)
smuzaffar added a commit that referenced this pull request Jan 4, 2019
GEN related PR: Updating configs in Configuration/Generator/python/ with new gridpacks to fix errors (ref. PR 25343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants