Avoid printing statistics if hadronizer has not been initialized properly

[makortel]

AddOn tests in #25577 showed a segfault in Pythia8::Pythia::stat() when an exception was thrown by another module in beginRun()

#4  <signal handler called>
#5  0x00007f26e3093e01 in Pythia8::Pythia::stat() () from .../external/slc7_amd64_gcc700/lib/libpythia8.so
#6  0x00007f26e5dbcca0 in Pythia8Hadronizer::statistics() () from .../lib/slc7_amd64_gcc700/pluginGeneratorInterfacePythia8Filters.so
#7  0x00007f26e5df82ba in edm::GeneratorFilter<Pythia8Hadronizer, gen::ExternalDecayDriver>::endRunProduce(edm::Run&, edm::EventSetup const&) () from .../lib/slc7_amd64_gcc700/pluginGeneratorInterfacePythia8Filters.so
#8  0x00007f27057736f3 in edm::one::EDFilterBase::doEndRun(edm::RunPrincipal const&, edm::EventSetup const&, edm::ModuleCallingContext const*) () from .../lib/slc7_amd64_gcc700/libFWCoreFramework.so
#9  0x00007f2705728420 in edm::WorkerT<edm::one::EDFilterBase>::implDoEnd(edm::RunPrincipal const&, edm::EventSetup const&, edm::ModuleCallingContext const*) () from .../lib/slc7_amd64_gcc700/libFWCoreFramework.so

A unit test with TestProcessor (included) confirms the segfault in case the Run has no LuminosityBlocks (in which case the Pythia8's initialization has not been called). This PR suggests to add a boolean flag to GeneratorFilter template to avoid calling the endRun statistics printouts if the hadronizer+decayer have not been initialized (assuming the endRun printout is really needed).

Tested in 10_4_0_pre4, no changes expected.

@Dr15Jones

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25579/7818

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

GeneratorInterface/Core
GeneratorInterface/Pythia8Interface

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32400/console Started: 2019/01/03 19:55

[cmsbuild]

+1
Tested at: 7f52ce4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25579/32400/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25579/32400/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153512
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[makortel]

ping

[fabiocos]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[fabiocos]

@qliphy @efeyazgan @alberto-sanchez the added test is successful, and the code update looks reasonable, could you please review and sign or comment?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25579/8002

• This PR adds an extra 20KB to repository

[fabiocos]

@qliphy @efeyazgan @alberto-sanchez the added test is successful, and the code update looks reasonable, could you please review and sign or comment?

[efeyazgan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1