Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of MTDTrackExtender and MTDClusterizer (#25063 squashed) #25612

Merged
merged 1 commit into from Jan 10, 2019

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jan 9, 2019

This is PR #25063 squashed into one commit.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

The code-checks are being triggered in jenkins.

@lgray
Copy link
Contributor Author

lgray commented Jan 9, 2019

@cmsbuild please test workflow 20434.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25612/7900

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

A new Pull Request was created by @lgray (Lindsey Gray) for master.

It involves the following packages:

Configuration/EventContent
Configuration/StandardSequences
DQM/TrackingMonitor
DataFormats/FTLRecHit
DataFormats/TrackReco
DataFormats/TrackerRecHit2D
Geometry/GlobalTrackingGeometryBuilder
RecoLocalFastTime/Configuration
RecoLocalFastTime/FTLClusterizer
RecoLocalFastTime/FTLRecProducers
RecoLocalFastTime/Records
RecoMTD/Configuration
RecoMTD/DetLayers
RecoMTD/MeasurementDet
RecoMTD/TrackExtender
RecoMTD/TransientTrackingRecHit
RecoMuon/GlobalTrackingTools
RecoMuon/L3MuonProducer
RecoMuon/MuonIdentification
RecoTracker/SpecialSeedGenerators
TrackingTools/RecoGeometry
TrackingTools/TrackRefitter

@perrotta, @cmsbuild, @andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @civanch, @fwyzard, @schneiml, @ianna, @mdhildreth, @Martin-Grunewald, @franzoni, @jfernan2, @kpedro88, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @abbiendi, @echapon, @fioriNTU, @threus, @hdelanno, @battibass, @makortel, @jhgoh, @dgulhan, @HuguesBrun, @drkovalskyi, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @jandrea, @mschrode, @idebruyn, @ebrondol, @mtosi, @amagitte, @Martin-Grunewald, @calderona, @bachtis, @gpetruc, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Jan 9, 2019

please test workflow 27634.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32498/console Started: 2019/01/09 17:26

@lgray
Copy link
Contributor Author

lgray commented Jan 9, 2019

@fabiocos thanks!

@cvuosalo
Copy link
Contributor

cvuosalo commented Jan 9, 2019

I can approve for geometry, but I am waiting for the comparisons to complete.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25612/32499/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153512
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@andrius-k
Copy link

+1

@fabiocos
Copy link
Contributor

@cvuosalo it would be good if we can merge it asap, unless you have further relevant comments

@kpedro88 @slava77 @Martin-Grunewald I assume your signatures are confirmed, otherwise please comment (anyway anew signature would be useful)

@kpedro88
Copy link
Contributor

+upgrade

@cvuosalo
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Jan 10, 2019

+1

for #25612 f5eb812

@slava77
Copy link
Contributor

slava77 commented Jan 10, 2019

(the new code affects only the workflows which are not a part of the standard jenkins baseline).

I'm correcting myself: the 27434 D35 WF is actually in the jenkins tests, but the default reco comparisons script is not set up to show a new collection if it's not in the baseline.

@fabiocos
Copy link
Contributor

+1

@Martin-Grunewald in case please sign it for reference (as it is the same that you already signed in #25063)

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 754ca6b into cms-sw:master Jan 10, 2019
@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants